Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fastqc specific workaround #80

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

phue
Copy link
Member

@phue phue commented Mar 6, 2019

This commit removes the fastqc specific dependencies which should be resolved upstream since
bioconda/bioconda-recipes#12616 was merged

Additionally it fixes the following:

  • significantly speeds up the creation of conda environments
  • with conda >4.6.7 building the environment failed with
    `UnsatisfiableError: The following specifications were found to be in conflict:
    • anaconda::font-ttf-dejavu-sans-mono=2.37
      Use "conda search --info" to see the dependencies for each package.`

This commit removes the fastqc specific dependencies which should be resolved upstream since
bioconda/bioconda-recipes#12616 was merged

Additionally it fixes the following:

* significantly speeds up the creation of conda environments
* with conda >4.6.7 building the environment failed with
`UnsatisfiableError: The following specifications were found to be in conflict:
  - anaconda::font-ttf-dejavu-sans-mono=2.37
Use "conda search <package> --info" to see the dependencies for each package.`
@phue phue requested a review from ewels March 6, 2019 18:43
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we can remove this again :)

@ewels ewels merged commit 3048667 into nf-core:dev Mar 6, 2019
@phue phue deleted the conda-cleanup branch April 9, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants