Skip to content

Update biohpc_gen.config #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update biohpc_gen.config #785

merged 1 commit into from
Mar 11, 2025

Conversation

nschan
Copy link
Contributor

@nschan nschan commented Oct 31, 2024

Remove resource limits params.

Remove resource limits params.
@nschan nschan requested a review from jfy133 October 31, 2024 15:01
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine but note that this will break for everything other than the most recent versions of pipelines, so it is at your own risk 😬

@nschan
Copy link
Contributor Author

nschan commented Oct 31, 2024

Is it a pipeline or a nextflow thing? I guess in that case I will wait a couple of months...

@jfy133
Copy link
Member

jfy133 commented Oct 31, 2024

Resource limits is a new native Nextflow thing to serve the same purpose as the original check_max and max_* params from nf-core.

Older versions of the nf-core pipelines will not receive updates to support this.

Note however keeping in the config will not harm current nor future pipelines.

But otherwise, yes wait a few months of most pipelines to update to the latest template and you can remove it (assuming you don't use older pipeline versions)

@Joon-Klaps
Copy link
Contributor

Hi @nschan,
Are you still testing this or do you need some help to push this over the finish line? 😄

@nschan
Copy link
Contributor Author

nschan commented Mar 11, 2025

Hi @Joon-Klaps

I think this can be merged, I mostly waited a bit to allow time for everyone to switch to newer nextflow versions

@Joon-Klaps Joon-Klaps merged commit b1a46f1 into master Mar 11, 2025
271 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2025 spring cleaning - the rest Mar 11, 2025
@Joon-Klaps Joon-Klaps deleted the biohpcgen-no-param-limits branch March 11, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants