-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dummy configs for all missing configs #674
Add dummy configs for all missing configs #674
Conversation
Not tested because on train |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we just need to be sure we add any new pipeline
If you want I can write a github action which periodically checks https://nf-co.re/pipeline_names.json and creates that. |
One thing I find sub-optimal: we now have |
both have different usage, but I see your point |
yes, different usage and same name is never good |
That would be awesome |
Should I wait for the GHA @mashehu before merging? But otherwise I will prepare the tools template to uncomment the relevant code, and update our new-project-guidance |
yes, I will add the GHA to this PR. Any chance we can use a different name than |
No I don't think so. It's already embedded in existing pipelines for a while, so if we changed it would break compatibility with old releases. @maxulysse correct me if I'm wrong |
okay, GHA is there. as usual need to really test it in production (I ran it locally with |
Looks good to me @mashehu ! If you can both review: nf-core/tools#2936 and re-review this one, then i will merge this PR and shortly after the tools one |
This is for allowing us to uncomment out the part in the pipeline template.
I wonder if it just works 'as is' or if we have to add an explicit profile or not... ideas @maxulysse ?