fix(autocomplete): missing popover props except content

[wingkwong]

Closes #4484

📝 Description

Currently when users pass popoverProps in Autocomplete, only content is passed. This PR is to include other popover props.

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• Bug Fixes
  • Resolved an issue with the @nextui-org/autocomplete package by adding missing popover properties
  • Improved popover styling capabilities by allowing additional class names to be applied

[changeset-bot]

🦋 Changeset detected

Latest commit: 82588c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/autocomplete	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 5, 2025 6:28am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 5, 2025 6:28am

[coderabbitai]

Walkthrough

This pull request addresses an issue with the @nextui-org/autocomplete package by modifying the getPopoverProps function in the use-autocomplete.ts file. The change specifically focuses on merging the classNames property from slotsProps.popoverProps into the returned popoverProps object, which aims to resolve a bug related to class name application for popover properties in the Autocomplete component.

Changes

File	Change Summary
packages/components/autocomplete/src/use-autocomplete.ts	Added line to merge classNames from slotsProps.popoverProps into popoverProps
.changeset/seven-news-melt.md	Patch file for the @nextui-org/autocomplete package

Assessment against linked issues

Objective	Addressed	Explanation
Fix base class not applying in Autocomplete popoverProps [#4484]	✅

Possibly related PRs

• fix: popover-based focus behaviour #2854: Focus behavior improvements in popovers
• fix(autocomplete): ignore pointer events when the clear button is hidden #3000: Event handling modifications in use-autocomplete.ts
• fix: interactions with popover & focus issues #3137: Popover focus management updates
• fix(autocomplete): maximum update depth exceeded #3175: Changes to use-autocomplete.ts
• fix(autocomplete): exit animation on popover close #3845: Popover behavior enhancements
• fix(autocomplete): validate prop not working after hovering #4452: Autocomplete validation behavior
• fix(autocomplete): clear autocomplete value when pressing clear button #4458: Clear button functionality improvements

Suggested reviewers

• jrgarciadev

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[linear]

ENG-1820 [BUG] - "base" Class Not Applying Correctly in Autocomplete Component for popoverProps

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/components/autocomplete/src/use-autocomplete.ts (1)

Line range hint 485-491: Ensure compatibility when merging classNames.

Merging classNames from slotsProps.popoverProps is a good step for better styling flexibility. However, be cautious about potential naming collisions or specificity issues. Make sure that when user-defined classes and default classes overlap, the intended styling always takes precedence.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a43b156 and 82588c7.

📒 Files selected for processing (2)

• .changeset/seven-news-melt.md (1 hunks)
• packages/components/autocomplete/src/use-autocomplete.ts (1 hunks)

🔇 Additional comments (1)

.changeset/seven-news-melt.md (1)

1-5: Changeset patch looks good.

The changeset correctly patches the @nextui-org/autocomplete package to address the missing popover properties. This is a straightforward implementation with no apparent issues.