fix(deps): bump @nextui-org/theme in peerDependencies#4334
Conversation
🦋 Changeset detectedLatest commit: 1111783 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request introduces a patch version update for the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)packages/components/radio/package.json (1)
The update to
packages/components/checkbox/package.json (1)
The update to Let's verify this change is applied consistently across all affected components: ✅ Verification successfulInconsistency found in theme peer dependency version The verification reveals that only checkbox, radio, and switch components have been updated to require 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for consistency of @nextui-org/theme peer dependency across components
# that might use the hiddenInput slot (checkbox, radio, switch, toggle)
# Search for package.json files in component directories
fd --type f "package.json" packages/components/ --exec grep -l "@nextui-org/theme" {} \; | \
while read -r file; do
echo "=== $file ==="
grep -A 1 "@nextui-org/theme" "$file"
done
Length of output: 15239 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/components/switch/package.json (1)
39-39: LGTM! Consider adding migration notesThe version bump to
>=2.4.3looks appropriate to fix the TypeError. However, since this is a more restrictive peer dependency that could affect users on versions 2.4.0-2.4.2:
- Consider adding a note in the changelog about the potential impact
- Update the component's documentation to mention the minimum required theme version
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
.changeset/famous-avocados-run.md(1 hunks)packages/components/switch/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .changeset/famous-avocados-run.md
🔇 Additional comments (1)
packages/components/switch/package.json (1)
39-39: Verify the theme package changes that necessitate this version bump
Let's verify the changes in the theme package between versions 2.4.0 and 2.4.3 to ensure this fixes the slots.hiddenInput TypeError.
✅ Verification successful
Based on the review of the code and changelog, I can now provide a definitive response about the theme version bump:
Version bump is necessary to fix the hiddenInput implementation
The change from >=2.4.0 to >=2.4.3 is justified based on the following findings:
- Version 2.4.3 contains critical fixes for interactive elements and build issues
- Version 2.4.2 specifically fixed issues #4252 and #4260 related to interactive elements not working properly
- The theme package exports
hiddenInputClassesfromutils/index.tswhich is used in the toggle component - The toggle component provides the base implementation for the switch component's hidden input functionality
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for relevant changes in the theme package
# Look for hiddenInput related changes in the theme package
rg -A 5 "hiddenInput" packages/components/theme/
# Check for breaking changes or fixes in theme package
rg -l "fix.*switch|break.*switch" .changeset/
Length of output: 163
Script:
#!/bin/bash
# Let's try different paths and approaches
# First, find the theme package location
fd -t d "theme$" packages
# Look for switch-related files and changes
rg -l "switch" packages
# Look for hiddenInput in all files
rg -l "hiddenInput" packages
# Check for any recent changesets
fd -e md .changeset
Length of output: 2169
Script:
#!/bin/bash
# Let's examine the switch component and theme implementation
# Check the switch component implementation
cat packages/components/switch/src/switch.tsx
# Check the theme's toggle component (which might be used for switch)
cat packages/core/theme/src/components/toggle.ts
# Look for recent changes in theme package
cat packages/core/theme/CHANGELOG.md
Length of output: 45390
wingkwong
changed the title
@nextui-org/theme in peerDependencies@nextui-org/theme in peerDependencies
2 participants
Closes #4332
📝 Description
In PR #4311, a new slot
hiddenInputhas been added to checkbox, radio, toggle in theme package. Therefore, the correspondingpeerDependenciesshould be also updated so that users can upgrade@nextui-org/themepackage automatically.⛳️ Current behavior (updates)
when users run
nextui upgrade --all,@nextui-org/themeis not upgraded because of the peerDependencies.🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes