Skip to content

fix: issue on RTL support checkbox component #2466

Merged
jrgarciadev merged 4 commits into
heroui-inc:mainfrom
mrbadri:fix/checkbox
Mar 8, 2024
Merged

fix: issue on RTL support checkbox component #2466
jrgarciadev merged 4 commits into
heroui-inc:mainfrom
mrbadri:fix/checkbox

Conversation

@mrbadri
Copy link
Copy Markdown
Contributor

@mrbadri mrbadri commented Mar 7, 2024

Closes #2465

📝 Description

Add RTL support to the checkbox component.

⛳️ Current behavior (updates)

The checkbox component currently lacks support for right-to-left (RTL) direction.

🚀 New behavior

This PR addresses the RTL support issue in the checkbox component, ensuring correct rendering in RTL environments.

💣 Is this a breaking change (Yes/No):

📝 Additional Information

close #2465

@mrbadri mrbadri requested a review from jrgarciadev as a code owner March 7, 2024 15:39
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: d2cd0b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/checkbox Patch
@nextui-org/table Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 0:00am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 0:00am

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 7, 2024

@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrbadri 🙏🏻 , please adjust the changeset

Comment thread .changeset/clean-tools-double.md Outdated
@mrbadri
Copy link
Copy Markdown
Contributor Author

mrbadri commented Mar 7, 2024

Thank you @mrbadri 🙏🏻 , please adjust the changeset

Hi jrgarciadev,
i resolves this

Copy link
Copy Markdown
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put the issue number next to Closes # (i.e. Closes #2465) instead of mentioning in additional info so that the issue can be closed automatically once it is merged.

@mrbadri
Copy link
Copy Markdown
Contributor Author

mrbadri commented Mar 8, 2024

wingkwong

Hi wingkwong,
i resolve this

@mrbadri mrbadri changed the title fix: issue on RTL support checkbox component #2465 fix: issue on RTL support checkbox component Mar 8, 2024
@mrbadri
Copy link
Copy Markdown
Contributor Author

mrbadri commented Mar 8, 2024

Hi jrgarciadev,

I hope you're doing well! I've made some updates to address the feedback you provided earlier. Could you please take another look at my pull request when you have a moment? Your feedback is greatly appreciated.

Thank you!

Mohammad Reza Badri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Lack of RTL Support in checkbox

3 participants