Skip to content

fix: #2382 typo in modal transition CSS variable access#2426

Merged
jrgarciadev merged 1 commit into
heroui-inc:mainfrom
markwilson:fix/typo-in-modal-transition
Mar 1, 2024
Merged

fix: #2382 typo in modal transition CSS variable access#2426
jrgarciadev merged 1 commit into
heroui-inc:mainfrom
markwilson:fix/typo-in-modal-transition

Conversation

@markwilson
Copy link
Copy Markdown
Contributor

Closes #2382

📝 Description

Fixes typo in CSS variable access syntax

⛳️ Current behavior (updates)

Console shows a warning and transition of modal doesn't complete as expected.

🚀 New behavior

No more warnings, transition works as expected.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@markwilson markwilson requested a review from jrgarciadev as a code owner March 1, 2024 15:29
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 3:32pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 1, 2024

🦋 Changeset detected

Latest commit: 2cc0ab0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/modal Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 1, 2024

@markwilson is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! @markwilson

@jrgarciadev jrgarciadev merged commit fa27bcc into heroui-inc:main Mar 1, 2024
@markwilson markwilson deleted the fix/typo-in-modal-transition branch March 2, 2024 17:39
@kuri-sun kuri-sun mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants