Skip to content

fix(input): resolve RTL support (#2315)#2316

Merged
jrgarciadev merged 5 commits into
heroui-inc:mainfrom
mrbadri:bug/rtl-support-input-issue-2315
Mar 16, 2024
Merged

fix(input): resolve RTL support (#2315)#2316
jrgarciadev merged 5 commits into
heroui-inc:mainfrom
mrbadri:bug/rtl-support-input-issue-2315

Conversation

@mrbadri
Copy link
Copy Markdown
Contributor

@mrbadri mrbadri commented Feb 5, 2024

Closes #2315

📝 Description

Add RTL support to the input component.

⛳️ Current behavior (updates)

The input component currently lacks support for right-to-left (RTL) direction.

🚀 New behavior

This PR addresses the RTL support issue in the input component, ensuring correct rendering in RTL environments.

💣 Is this a breaking change (Yes/No):

📝 Additional Information

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: fab4f9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/input Patch
@nextui-org/autocomplete Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2024

@mrbadri is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@mrbadri mrbadri requested a review from jrgarciadev as a code owner February 5, 2024 18:20
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 10:20pm

@jrgarciadev
Copy link
Copy Markdown
Member

Hi @mrbadri, thank you for submitting this pull request. I will review it shortly

@jrgarciadev
Copy link
Copy Markdown
Member

@mrbadri it worked fine, thank you!, could you please add the changeset?

@mrbadri
Copy link
Copy Markdown
Contributor Author

mrbadri commented Feb 18, 2024

Hi jrgarciadev, thank you for review my pull request

when i run 'pnpm changeset'
i get this error :
🦋 Which packages would you like to include? · No items were selected
🦋 error You must select at least one package to release
🦋 error (You most likely hit enter instead of space!)

i can't add changeset

@mrbadri
Copy link
Copy Markdown
Contributor Author

mrbadri commented Feb 21, 2024

Hi jrgarciadev,
I add changeset

Comment thread .changeset/curly-pandas-guess.md Outdated
@itmysm
Copy link
Copy Markdown

itmysm commented Mar 4, 2024

Hi Mohammad Reza! if you need any help with RTL support, I'm ready to help you.

@mrbadri
Copy link
Copy Markdown
Contributor Author

mrbadri commented Mar 8, 2024

Hi jrgarciadev,

I hope you're doing well! I've made some updates to address the feedback you provided earlier. Could you please take another look at my pull request when you have a moment? Your feedback is greatly appreciated.

Thank you!

Mohammad Reza Badri

Copy link
Copy Markdown
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @mrbadri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Lack of RTL Support in Input

3 participants