Skip to content

fix(components): number input label #2268 fixed#2274

Merged
jrgarciadev merged 4 commits into
heroui-inc:mainfrom
Prakash7895:fix/number-input-label
Feb 22, 2024
Merged

fix(components): number input label #2268 fixed#2274
jrgarciadev merged 4 commits into
heroui-inc:mainfrom
Prakash7895:fix/number-input-label

Conversation

@Prakash7895
Copy link
Copy Markdown
Contributor

Closes #2268

📝 Description

When using a number input and with a 0 for the initial value, the label (default or labelPlacement='inside') does not animate to the correct position. Even when the user is setting the value to 0, the label does not alter its state unless a number other than 0 is inputted.

⛳️ Current behavior (updates)

When defaultValue or value prop set as 0, label do not move to correct position.

🚀 New behavior

When defaultValue or value prop set as 0, label moves to correct position.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 21, 2024

🦋 Changeset detected

Latest commit: 0e68c1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/input Patch
@nextui-org/autocomplete Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/components/input/src/use-input.ts Outdated
Comment thread packages/components/input/src/use-input.ts Outdated
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:05am

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2024

@Prakash7895 is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@jrgarciadev
Copy link
Copy Markdown
Member

@Prakash7895 could you please fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Number input label

4 participants