Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-range-picker): input field clear error #3409

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fix(date-range-picker): input field clear error #3409

merged 1 commit into from
Jul 6, 2024

Conversation

ShrinidhiUpadhyaya
Copy link
Contributor

@ShrinidhiUpadhyaya ShrinidhiUpadhyaya commented Jul 3, 2024 •
edited by coderabbitai bot
Loading

Closes #3388

📝 Description

When you clear any fields inside the input of DateRangePicker you get the following errors.

Storybook

image

Docs

image

image

⛳️ Current behavior (updates)

Errors as shown above

🚀 New behavior

No errors

💣 Is this a breaking change (Yes/No):

📝 Additional Information

If the PR gets accepted please use my GitHub email-id ([email protected]) instead of my other email-id for the Co-authored-by: message.

Summary by CodeRabbit

  • Bug Fixes
    • Improved date-range-picker to handle potential null or undefined values for start property, ensuring more robust performance and fewer errors.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: 765ef5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:16pm

@vercel Vercel
Copy link

vercel bot commented Jul 3, 2024

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 3, 2024 •
edited
Loading

Walkthrough

The changes involve modifying the DateRangePicker component to prevent errors when a date field's value is cleared. This is achieved by using optional chaining (?.) to handle null or undefined values when accessing the start property of the value object. Both the presets.ts file and the date-range-picker.stories.tsx file are updated to implement this solution.

Changes

File Path Change Summary
apps/docs/content/components/date-range-picker/presets.ts Updated focusedValue to use optional chaining (value?.start) to handle null values.
packages/components/date-picker/stories/date-range-picker.stories.tsx Updated focusedValue assignment to handle potential null values using optional chaining (value?.start).

Assessment against linked issues

Objective Addressed Explanation
Fix error when clearing any field value in DateRangePicker (#3388). ✅

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ShrinidhiUpadhyaya ShrinidhiUpadhyaya changed the title fix(date-range-picker): error on clear #3388 fix(date-range-picker): input field clear error #3388 Jul 3, 2024
coderabbitai[bot]
coderabbitai bot reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec7c417 and 765ef5a.

Files selected for processing (2)
  • apps/docs/content/components/date-range-picker/presets.ts (1 hunks)
  • packages/components/date-picker/stories/date-range-picker.stories.tsx (1 hunks)
Additional comments not posted (2)
apps/docs/content/components/date-range-picker/presets.ts (1)

91-91: Good use of optional chaining to prevent errors.

The change to use optional chaining (?.) for focusedValue is a good practice to handle potential null or undefined values, thereby preventing runtime errors.

packages/components/date-picker/stories/date-range-picker.stories.tsx (1)

352-352: Good use of optional chaining to prevent errors.

The change to use optional chaining (?.) for focusedValue is a good practice to handle potential null or undefined values, thereby preventing runtime errors.

@wingkwong wingkwong changed the title fix(date-range-picker): input field clear error #3388 fix(date-range-picker): input field clear error Jul 4, 2024
@wingkwong wingkwong added this to the v2.4.3 milestone Jul 4, 2024
@jrgarciadev jrgarciadev merged commit 9806d1c into nextui-org:canary Jul 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@jrgarciadev jrgarciadev jrgarciadev approved these changes

@wingkwong wingkwong wingkwong approved these changes

Assignees

@jrgarciadev jrgarciadev

Labels
None yet
Projects
None yet
Milestone
v2.4.3
Development

Successfully merging this pull request may close these issues.

[BUG] - DateRangePicker throws an error when I clear any time data
3 participants
@ShrinidhiUpadhyaya @jrgarciadev @wingkwong