static-site: Configure and use ESLint #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--hwsbs2
Generated with NPM version 8.19.4.
victorlin
force-pushed
the
victorlin/eslint
branch
from
38f072a to
f817111
Compare
victorlin
force-pushed
the
victorlin/eslint
branch
from
f817111 to
875ff4b
Compare
victorlin
force-pushed
the
victorlin/eslint
branch
from
4716c4f to
6083dc5
Compare
victorlin
commented
Jan 13, 2024
This project was previously unlinted. Add the necessary configuration including rule exceptions to make the linter run without error on the code as-is.
Helpful to see if errors aren't showing because of a configuration issue or simply because the file isn't being linted.
The last reference was removed in "Convert header to use Flex objects" (03f9e01).
From react-hooks/exhaustive-deps warning: React Hook useEffect has missing dependencies: 'getGroupLogo' and 'logo'. Either include them or remove the dependency array. You can also do a functional update 'setLogo(l => ...)' if you only need 'logo' in the 'setLogo' call
Parallels the rule configuration in Auspice: <nextstrain/auspice@9d5db44>
Add rule exceptions to allow the linter run without error on the code as-is.
The last reference was removed in "Swap to iFrame for SARS-CoV-2 forecasts page" (3b668d6).
This was added in "static-site: Import individual config values explicitly" (554b611) without realizing that the variable was no longer available in the config file.
Previous commits addressed all violations.
victorlin
force-pushed
the
victorlin/eslint
branch
from
6083dc5 to
225accd
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This project was previously unlinted. Add the necessary configuration including rule exceptions to make the linter run without error on the code as-is.
Related issue(s)
Fixes #775
Checklist