Fix back button breaks #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `changePage` action, use `chooseDisplayComponentFromURL(path)` to determine what to set as `displayComponent`. This has some hard coded known url parts that should display the Auspice splash page instead of a dataset.
The "local" prefix in URLs is left over from a former way of accessing datasets & narratives but is no longer used.
|
Thanks @joverlee521, really great to have this bug fixed 🎉 😄 👍 I've added a commit to remove the logic surrounding pathnames starting with "local" which haven't been used in a long time. In the long run this logic (which is largely specific to nextstrain.org) shouldn't be in the auspice codebase, but this fix is a big improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #815.
Use existing function
chooseDisplayComponentFromURLto determine what to set as thedisplayComponentinstead of hard coding to "datasetLoader".This function includes known urls that are hardcoded to display the Auspice splash page and I've added "group" to this list.