Replace remote styles and fonts with the ones served locally #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the PR @ivan-aksamentov! 🙌This looks like a nice improvement. Brief perusal looks great to me, but I'll defer to @jameshadfield for full review. |
jameshadfield
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
This is great, thanks @ivan-aksamentov for contributing your time here!
The changes look good from my point of view. Increased offline functionality (and aesthetics!) will be a big asset for auspice going forward.
This PR has made me realise that (I think!) we don't actually use font-awesome, however this is a separate issue.
jameshadfield
added a commit
that referenced
this pull request
Nov 27, 2019
The directory structure of npm dependencies is different
depending on whether auspice is installed from source, a
global npm install or a project's dependency. E.g. for webpack
to process the `font-awesome` dependency, then:
Global install & from source: `${__dirname}/node_modules/font-awesome`
Project dependency: `${__dirname}/../font-awesome`
This bug comes from #826 which specified the first of the above
two scenarios.
Tested with projects using auspice (incl client-side customisations)
via global npm auspice isntall, npm dependency and `npm link <path>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address some of the points in issue #714 (Improve offline functionality):
leaflet's stylesheets are now bundled with webpack.font-awesome's stylesheets and fonts are are now bundled with webpack. Officialfont-awesomepackage is added as a dependency.typeface-latois added. This package includeswoffandwoff2formats and this should cover the majority of target browsers, including IE 9 and Safari 5 (see: caniuse.com/woff)Verification
git clone https://github.com/nextstrain/auspice cd auspice git pull origin pull/826/head-domain:localhost(meaning "not", "domain", "localhost").api.mapbox.comand, eventually,chrome-extension://*/backend.jsfrom installed Chrome extensions.