Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include strain metadata accession #819

Merged
merged 4 commits into from
Nov 5, 2019

Conversation

joverlee521
Copy link
Contributor

Includes the GISAID EPI Isolate ID in the strain metadata download.

This is a bugfix as the (strain-related) URL was not being exported as per the v2 schema. See also 4989b30
This functionality was present in auspice v1 but broken during the move to v2. Includes some comments in the codebase for future refactoring.
@jameshadfield
Copy link
Member

Hi @joverlee521, thanks for addressing this bug introduced in the v2 release. I think it's great that there is good feedback from the flu community and that you can address bugs like these 👍

I've fixed a couple of additional bugs related to your one. A strain's url wasn't being converted to the v2 format either (identical issue to accession). And neither accession nor url were being displayed in the tip-clicked info box, which is a regression from v1.

@jameshadfield jameshadfield merged commit b04ff84 into master Nov 5, 2019
@jameshadfield jameshadfield deleted the include-strain-metadata-accession branch November 5, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants