Replace jest-puppeteer with Playwright #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage was removed in "Remove integration tests" (2047696).
nextstrain-bot
temporarily deployed
to
auspice-victorlin-smoke-hnkmwg
Advantages of the new Playwright setup: 1. It auto-detects whether a server is already running (no need for two separate npm scripts) 2. Browser installation is done in a separate command. Previously, it was done on installation of puppeteer which became difficult to debug when it timed out on remote build environments. 3. It requires much fewer dependencies (see diff of package-lock.json)
The default parallelization of Playwright tests will parallelize across multiple test files, but not within each file. There is currently only one test file, so it makes sense to parallelize within the file. <https://playwright.dev/docs/test-parallel#parallelize-tests-in-a-single-file>
victorlin
force-pushed
the
victorlin/smoke-tests
branch
from
cc61b5d to
f4ec004
Compare
jameshadfield
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Advantages of the new Playwright setup:
Related issue(s)
Checklist
If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.