download: use the node.shell.inView property
#1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node.inView` property is a temporary hold for the node's inView property to be able to zoom in on specific branches before the D3 PhyloTree has been constructed. Once the D3 PhyloTree has been constructed, the inView property is available through `node.shell.inView`. This is the property that gets updated by `applyInViewNodesToTree` whenever the user interacts with any zooming functionality on the tree. The temporary `node.inView` property will never be updated and thus only represents the initial state of the node when the tree was first loaded. Therefore, any downstream uses of the inView property should be using the `node.shell.inView` property.
jameshadfield
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Thanks @joverlee521 - was able to recreate the error from #1411 (comment) & confirm this fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
node.inViewproperty is a temporary hold for the node's inView property to be able to zoom in on specific branches before the D3 PhyloTree has been constructed.Once the D3 PhyloTree has been constructed, the inView property is available through
node.shell.inView. This is the property that gets updated byapplyInViewNodesToTreewhenever the user interacts with any zooming functionality on the tree. The temporarynode.inViewproperty will never be updated and thus only represents the initial state of the node when the tree was first loaded.Therefore, any downstream uses of the inView property should be using the
node.shell.inViewproperty.Related issue(s)
Fixes #1411
Testing