Continous scale fixes 2 #1657
Merged
Continous scale fixes 2 #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Tested and it fixes #1654 indeed!
Tested here using logistic growth and hovering over the minimum in the scale: https://auspice-continous-scale-az6dwn.herokuapp.com/ncov/gisaid/europe?c=logistic_growth
joverlee521
reviewed
Mar 27, 2023
jameshadfield
force-pushed
the
continous-scale-fixes-2
branch
from
db10308
to
1cd02a4
Compare
jameshadfield
force-pushed
the
continous-scale-fixes
branch
from
c7ac36f
to
eca540e
Compare
This is very rarely used (note that even datasets without any coloring have `colorBy="numDate"` due to hardcoded defaults). By removing the unneeded call to `createLegendBounds` we make it easier to improve that function.
Previously the creation of legend bounds for continuous scales used hardcoded minimum (0) and maximum (10,000). This may result in the first and/or last legend entry having associated bounds which could never match any values. Given the various locations this function is called it's easier to set the min/max as (-)Infinity rather than consider the observed min/max. Closes #1644 Closes #1654
jameshadfield
force-pushed
the
continous-scale-fixes-2
branch
from
1cd02a4
to
17d8ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Given how minor these changes ended up being I'm happy to merge without review but I'll give it a day or two if anyone would like to take a look 🙏 👀
P.S. Typescript would have been so helpful for this PR (as well as #1655).