Fix frequency colors for ordinal scales #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying bug was a type-inconsistency whereby color-by values can be numeric however the matrix was stored as an Object (where keys are always stringified) and so `matrix[numeric_colorBy_value]=undefined`. Switching to a Map() allows typed keys and fixes this bug. Closes #843
nextstrain-bot
temporarily deployed
to
auspice-bug-ordinal-sca-n0fxpc
|
Tested using the flu dataset from the original issue. Will merge now so that we can release in time for the next nCoV build which will include (ordinal) RBD Levels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying bug was a type-inconsistency whereby color-by values can be numeric however the matrix was stored as an Object (where keys are always stringified) and so
matrix[numeric_colorBy_value]=undefined. Switching to a Map() allows typed keys and fixes this bug.Closes #843