Clip tree to improve visibility of axes #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximizes the amount of space available for rendering, whilst still allowing axes labels as needed. Moving the `margins` definitions into `mapToScreen()` makes them easier to reason with.
This (essentially) clips branches, tips and grids to the range of the
{x,y} scales in order to prevent branches / tips from obscuring the axes
The clipping of grid lines in radial view is not perfect here.
This was referenced Jul 28, 2021
|
Merging after further testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (essentially) clips branches, tips and grids to the range of the
{x,y} scales in order to prevent branches / tips from obscuring the axes
This works well on the scatterplots I've thrown at it, but a bit more testing is needed. I haven't tested the slowdown (if any) which I'll do before merging.
The display of y-axis tick labels is another area of improvement to make for scatterplots