Update webpack chunk-hash-generation settings #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `HashedModuleIdsPlugin` from the build pipeline as we use `WebpackChunkHash` to generate contenthash for each chunk. This caused hard-to-debug bugs in auspice (and nextstrain.org) where a hash was being generated from the pre-minified (etc) bundle contents, but different minification resulted in different bundle contents. As the bundle name was the same, clients could use their (out-of-date) cached version, which would result in a variety of errors in auspice.
jameshadfield
temporarily deployed
to
auspice-webpack-hash-jfcwfc7kn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
HashedModuleIdsPluginfrom the build pipeline aswe use
WebpackChunkHashto generate contenthash for each chunk.This caused hard-to-debug bugs in auspice (and nextstrain.org)
where a hash was being generated from the pre-minified (etc)
bundle contents, but different minification resulted in different
bundle contents. As the bundle name was the same, clients could
use their (out-of-date) cached version, which would result in
a variety of errors in auspice.