Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove font-awesome and use react-icons #1065

Closed
wants to merge 1 commit into from
Closed

Remove font-awesome and use react-icons #1065

wants to merge 1 commit into from

Conversation

joachimschmidt557
Copy link
Contributor

Description of proposed changes

Remove all font-awesome CSS and use react-icons instead

Related issue(s)

Fixes #566

jameshadfield
jameshadfield approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks. I'm going to merge after rebasing onto current master to sort out the package-lock.json

@jameshadfield
Copy link
Member

This PR has been merged in via 0c5721e

@jameshadfield jameshadfield mentioned this pull request Apr 16, 2020
Closed
@joachimschmidt557 joachimschmidt557 deleted the react-icons branch April 16, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshadfield jameshadfield jameshadfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove font-awesome CSS import
2 participants
@joachimschmidt557 @jameshadfield