Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 'turn off' of all filters, not just individual ones #1358

Closed
emmahodcroft opened this issue Jun 10, 2021 · 2 comments · Fixed by #1371
Closed

Allow 'turn off' of all filters, not just individual ones #1358

emmahodcroft opened this issue Jun 10, 2021 · 2 comments · Fixed by #1371
Labels
enhancement New feature or request

Comments

@emmahodcroft
Copy link
Member

Context
When trying to inspect a set of filtered tips, one cannot zoom in so easily if only one filtered tip is visible. The best thing to do is turn off all filters, then click on the branch you want, then turn filters back on. However, for multiple tips, this takes ages to turn them on and off when switching views.

turnOffFilterTips

Possible Solution
Perhaps alongside the 'delete all' icon below the 'Filter Data' on the menu, there could be a 'hide all' option? So that one could hide and unhide all the sample filters at once, to allow for more easy zooming in and out?

image

Examples
With any set of multiple tips on filter, try to zoom in and out to look at them each more closely in turn, without accidentally deleting any along the way :)
https://nextstrain.org/ncov/europe?c=S1_mutations&s=France/PAC-IHU-3126i/2020,India/MH-NIV-8404/2020,Mongolia/7908/2020,Peru/LIM-INS-768/2020
@emmahodcroft emmahodcroft added the enhancement New feature or request label Jun 10, 2021
@jameshadfield
Copy link
Member

Perhaps alongside the 'delete all' icon below the 'Filter Data' on the menu, there could be a 'hide all' option? So that one could hide and unhide all the sample filters at once, to allow for more easy zooming in and out?

I've often wanted this!

jameshadfield added a commit that referenced this issue Jul 9, 2021
@jameshadfield
Allow hiding of all filters in a category
d81700f 
Expands the functionality of the sidebar filter badges to allow inactivation of all (active) filters in a category.

The choice was made to keep a sidebar badge "active" if any of its constituent filters was active. For example, if there were a mixture of 3 active and 2 inactive country filters (displayed at the top of the page), then the sidebar badge will be active and show "3 x country", with the option to inactivate those 3 filters, or remove all 5.

Closes #1358
@jameshadfield jameshadfield mentioned this issue Jul 9, 2021
Merged
@jameshadfield
Copy link
Member

jameshadfield commented Jul 9, 2021 •
edited
Loading

@emmahodcroft would you mind testing PR #1371 // https://nextstrain-s-auspice-pr-zsssjw.herokuapp.com/ncov/open/global? I think this is a clear improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow hiding of all filters in a category nextstrain/auspice
3 participants
@trvrb @jameshadfield @emmahodcroft