Skip to content

Commit

Permalink
[bugfix] typo in tree visibility property
Browse files Browse the repository at this point in the history
Oh how TypeScript would have helped!

This bug was found while debugging the ability to show genotype
colorings on both trees (added in the parent commit) where the
visibility of the second tree was `undefined` upon loading, leading to
`createVisibleLegendValues` not considering the second tree and thus
removing legend items which were only observed in the second tree.

Bug introduced ~4 years ago via 391bca4
although its effect was minor (and probably never noticed?)
  • Loading branch information
jameshadfield committed Jun 10, 2024
1 parent d540022 commit a87c595
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/actions/recomputeReduxState.js
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,7 @@ export const createStateFromQueryOrJSONs = ({
treeNodes: tree.nodes,
treeTooNodes: treeToo ? treeToo.nodes : undefined,
visibility: tree.visibility,
visibilityToo: treeToo ? treeToo.visibilityToo : undefined
visibilityToo: treeToo?.visibility,
});

/* calculate entropy in view */
Expand Down

0 comments on commit a87c595

Please sign in to comment.