Merge pull request #1906 from nextstrain/james/entropy-fixes

Entropy bug fixes
nextstrain · Nov 18, 2024 · 7ec0222 · 7ec0222
2 parents 522c21d + 117deb2
commit 7ec0222
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/actions/entropy.js b/src/actions/entropy.js
@@ -24,7 +24,7 @@ export const updateEntropyVisibility = debounce((dispatch, getState) => {
 
   const [data, maxYVal] = calcEntropyInView(tree.nodes, tree.visibility, entropy.selectedCds, entropy.showCounts);
   dispatch({type: types.ENTROPY_DATA, data, maxYVal});
-}, 500, { leading: false, trailing: true });
+}, 500, { leading: true, trailing: true });
 
 /**
  * Returns a thunk which makes zero or one dispatches to update the entropy reducer

diff --git a/src/components/entropy/entropyD3.js b/src/components/entropy/entropyD3.js
@@ -64,8 +64,9 @@ EntropyChart.prototype.update = function update({
     this._setZoomBounds();
   }
 
+  if (showCounts!==undefined) this.showCounts = showCounts;
+
   if (newBars || selectedPositions!==undefined) {
-    if (showCounts!==undefined) this.showCounts = showCounts;
     if (newBars) {
       this.bars = newBars[0];
       this._updateOffsets();
@@ -75,6 +76,8 @@ EntropyChart.prototype.update = function update({
     if (selectedPositions !== undefined) {
       this.selectedPositions = selectedPositions;
     }
+    /* TODO XXX: there's a potential bug here if selectedCds is set but we don't enter this code block
+    due to the (newBars || selectedPositions!==undefined) conditional */
     if (selectedCds || selectedPositions !== undefined) {
       this._setZoomCoordinates(zoomMin, zoomMax, !!selectedCds);
     }