Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Restore read_metadata and supporting file #972

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jun 16, 2022

Description of proposed changes

This reverts commit 040822c.

As discussed in #970, there are still some references to augur.utils.read_metadata in core Nextstrain workflows.

See #970 (comment) for plans to add this change back.

Related issue(s)

Testing

See checks.

This reverts commit 040822c.

As discussed in #970, there
are still some references to augur.utils.read_metadata in core
Nextstrain workflows.

See #970 (comment)
for plans to add this change back.
@victorlin victorlin requested a review from a team June 16, 2022 20:26
@victorlin victorlin self-assigned this Jun 16, 2022
@victorlin victorlin changed the title utils: Revert removal of read_metadata and supporting file utils: Restore read_metadata and supporting file Jun 16, 2022
@victorlin victorlin added this to the Major release 16.0.0 milestone Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #972 (7a201a6) into master (0d3f4c4) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   58.99%   59.31%   +0.32%     
==========================================
  Files          49       50       +1     
  Lines        6201     6250      +49     
  Branches     1575     1582       +7     
==========================================
+ Hits         3658     3707      +49     
  Misses       2283     2283              
  Partials      260      260              
Impacted Files Coverage Δ
augur/util_support/metadata_file.py 100.00% <100.00%> (ø)
augur/utils.py 64.83% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3f4c4...7a201a6. Read the comment docs.

@victorlin victorlin merged commit 076816e into master Jun 16, 2022
@victorlin victorlin deleted the victorlin/revert-removal-of-utils-read-metadata branch June 16, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant