Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move --quiet flag to accommodate snakemake=7.7.0 behavior #927

Merged
merged 1 commit into from
May 17, 2022

Conversation

victorlin
Copy link
Member

Note: I would rather see the Snakemake issue addressed than have this PR merged.

Description of proposed changes

Snakemake 7.7.0 will try to read any target following --quiet as a parameter to the argument, which is unintended here. See failing CI run.

Related issue(s)

Testing

See test runs.

Snakemake 7.7.0 will try to read any target following --quiet as a parameter to the argument, which is unintended here.
@victorlin victorlin self-assigned this May 16, 2022
@victorlin victorlin changed the title Move --quiet flag to accommodate snakemake=7.7.0 behavior ci: Move --quiet flag to accommodate snakemake=7.7.0 behavior May 16, 2022
@victorlin
Copy link
Member Author

Don't think the Snakemake issue will be resolved anytime soon, so I'm merging this to get CI working in the short-term.

@victorlin victorlin marked this pull request as ready for review May 17, 2022 04:39
@victorlin victorlin merged commit 440f7c6 into nextstrain:master May 17, 2022
@victorlin victorlin deleted the ci/fix-snakemake-quiet branch May 17, 2022 04:39
@victorlin victorlin added this to the Major release 16.0.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant