Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix augur index I/O #900

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix augur index I/O #900

merged 2 commits into from
Apr 25, 2022

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Apr 22, 2022

Description of proposed changes

Fix a couple of I/O issues with the augur index command including:

  • Properly handle missing inputs for augur index, fixing a bug where a FileNotFoundError was not being caught and handled properly (and the exception handler that did exist referenced a variable that did not exist).
  • Use standard UNIX-style line endings for index output, for consistency across Augur outputs.

Testing

  • Adds functional tests for the index command
  • Tested by CI

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #900 (0e164de) into master (002c44f) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   34.62%   34.63%           
=======================================
  Files          42       42           
  Lines        6007     6006    -1     
  Branches     1538     1538           
=======================================
  Hits         2080     2080           
+ Misses       3854     3853    -1     
  Partials       73       73           
Impacted Files Coverage Δ
augur/index.py 65.75% <33.33%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002c44f...0e164de. Read the comment docs.

huddlej added 2 commits April 22, 2022 14:44
Fixes a bug in augur index where a FileNotFoundError was not being
caught and handled properly (and the exception handler that did exist
referenced a variable that did not exist).
Sets standard UNIX-style line endings for sequence index outputs, for
consistency across Augur outputs.
augur/index.py Show resolved Hide resolved
@huddlej huddlej added this to the Next release X.X.X milestone Apr 25, 2022
@huddlej huddlej merged commit f78958d into master Apr 25, 2022
@huddlej huddlej deleted the fix-index-io branch April 25, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants