Fix single trait inference #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds simplest call to traits and then two cases when traits should print a warning to stderr instead of throwing an error.
Follow convention by printing warnings and errors to stderr instead of stdout.
huddlej
force-pushed
the
fix-single-trait-inference
branch
from
fcb96df to
a7fce8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
+ Coverage 34.64% 36.89% +2.24%
==========================================
Files 41 42 +1
Lines 6003 6418 +415
Branches 1536 1685 +149
==========================================
+ Hits 2080 2368 +288
- Misses 3850 3949 +99
- Partials 73 101 +28
Continue to review full report at Codecov.
|
joverlee521
reviewed
Apr 15, 2022
Checks for missing values (i.e., `None`) instead of any false-y values that could be valid and desired (e.g., 0.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixes an issue where trait inference on a metadata column with a single value can cause an
AttributeErrorwhen the user (or workflow) requests confidence intervals or entropy and TreeTime has not calculated any.Related issue(s)
This issue was reported at least three separate times and commented on several times in at least one of these original issues.
Fixes #575
Fixes #715
Fixes #828
Testing
augur traits