Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send filter warnings to stderr #862

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

victorlin
Copy link
Member

Description of proposed changes

To be consistent with other warnings, for example:

  • print(f"WARNING: A 'date' column could not be found to group-by year or month.", file=sys.stderr)
  • print(f"WARNING: Some of the specified group-by categories couldn't be found: {', '.join(unknown_groups)}", file=sys.stderr)
  • augur/augur/filter.py

    Lines 1617 to 1621 in e4fdf59

    print(
    "WARNING: The sequence index is out of sync with the provided sequences.",
    "Metadata and strain output may not match sequence output.",
    file=sys.stderr
    )

Caught the inconsistency while implementing 9bcbccc6.

Related issue(s)

None

Testing

Updated tests accordingly.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #862 (6cf8d73) into master (bdfbe82) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   34.27%   34.31%   +0.03%     
==========================================
  Files          41       41              
  Lines        5941     5937       -4     
  Branches     1520     1518       -2     
==========================================
+ Hits         2036     2037       +1     
+ Misses       3823     3818       -5     
  Partials       82       82              
Impacted Files Coverage Δ
augur/filter.py 68.28% <0.00%> (ø)
augur/validate.py 40.59% <0.00%> (-0.90%) ⬇️
augur/export_v2.py 11.03% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfbe82...6cf8d73. Read the comment docs.

@victorlin victorlin requested a review from a team March 11, 2022 18:51
@victorlin victorlin merged commit b9e0c79 into nextstrain:master Mar 11, 2022
@victorlin victorlin deleted the group-by-warning branch March 11, 2022 20:27
@victorlin victorlin added this to the Next release X.X.X milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants