feat: improve error handling with hint #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 33.81% 33.79% -0.02%
==========================================
Files 41 41
Lines 5900 5903 +3
Branches 1465 1465
==========================================
Hits 1995 1995
- Misses 3822 3825 +3
Partials 83 83
Continue to review full report at Codecov.
|
joverlee521
reviewed
Dec 16, 2021
joverlee521
approved these changes
Dec 16, 2021
|
This seems like a good idea to me Cornelius! Helping to avoid cryptic error messages makes a huge difference. Thanks for tackling it! |
emmahodcroft
approved these changes
Dec 16, 2021
victorlin
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Provides helpful error message when root is not found in tree
Related issue(s)
resolves #815