Refactor subsampling into its own function #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 31.54% 31.52% -0.02%
==========================================
Files 41 41
Lines 5751 5754 +3
Branches 1389 1389
==========================================
Hits 1814 1814
- Misses 3860 3865 +5
+ Partials 77 75 -2
Continue to review full report at Codecov.
|
Adds a new function `subsample` with the logic originally defined in `run`. This new function allows us to reorganize the `run` function more substantially and confidently split the subsampling logic into more manageable components.
huddlej
force-pushed
the
refactor-subsampling
branch
from
86ef7a1 to
1983837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds a new function
subsamplewith the logic originally defined inrun. This new function allows us to reorganize therunfunction more substantially and confidently split the subsampling logic into more manageable components.Related issue(s)
Builds on #743 and #745.
Related to #699.
Testing
No additional testing besides CI tests.