Clean up tests #703
Merged
Clean up tests #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the "compressed" Zika build does not used compressed inputs/outputs yet, so this deletes those unnecessary tests that are already in the main Zika build and speeds up CI by a bit.
Deletes log files produced by functional tests of tree and removes a subpar unit test that creates an alignment FASTA file and never cleans it up. The unit test was already documented as "not a great test" and I agree that it's not necessary. Fixes #700
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 30.97% 30.88% -0.09%
==========================================
Files 41 41
Lines 5644 5644
Branches 1364 1364
==========================================
- Hits 1748 1743 -5
- Misses 3823 3827 +4
- Partials 73 74 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes log files produced by functional tests of tree and removes a subpar unit test that creates an alignment FASTA file and never cleans it up. The unit test was already documented as "not a great test" and I agree that it's not necessary.
This PR also removes redundant functional tests that I added in the Zika compressed build and that only slow down testing locally and in CI.
Fixes #700
Supersedes #701