Use correct Python versions in CI environments #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Travis CI runs one build for three major Python versions except each environment installs and uses the same Python 3.6 version from a fixed conda environment file. This change follows the recommendations from the conda documentation [1] to build each conda environment with the Travis Python version variable and the `conda create` command instead of the `conda env create` command. The cost of duplicating our dependencies here is small compared to the benefit of testing Augur with the appropriate Python versions. Fixes #626 [1] https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/use-conda-with-travis-ci.html
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 28.76% 29.09% +0.32%
==========================================
Files 39 39
Lines 5409 5434 +25
Branches 1332 1332
==========================================
+ Hits 1556 1581 +25
Misses 3795 3795
Partials 58 58
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Travis CI runs one build for three major Python versions except each environment installs and uses the same Python 3.6 version from a fixed conda environment file. This change follows the recommendations from the conda documentation to build each conda environment with the Travis Python version variable and the
conda createcommand instead of theconda env createcommand. The cost of duplicating our dependencies here is small compared to the benefit of testing Augur with the appropriate Python versions.Fixes #626