Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prototype script to identify emerging clades #653

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Dec 31, 2020

Adds a command line script that fetches an existing Nextstrain build's tree and frequencies JSONs and tries to find emerging subclades within currently annotated clades.

huddlej and others added 2 commits October 22, 2020 15:16
Adds a command line script that fetches an existing Nextstrain build's
tree and frequencies JSONs and tries to find emerging subclades within
currently annotated clades.
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #653 (e8620d1) into master (e209103) will increase coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   28.59%   29.37%   +0.78%     
==========================================
  Files          39       39              
  Lines        5355     5703     +348     
  Branches     1314     1488     +174     
==========================================
+ Hits         1531     1675     +144     
- Misses       3768     3943     +175     
- Partials       56       85      +29     
Impacted Files Coverage Δ
augur/tree.py 8.42% <0.00%> (-1.22%) ⬇️
augur/utils.py 37.33% <0.00%> (+3.14%) ⬆️
augur/filter.py 49.30% <0.00%> (+4.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e209103...e8620d1. Read the comment docs.

@trvrb
Copy link
Member Author

trvrb commented Dec 31, 2020

@huddlej ---

Thanks so much for putting this script together. I was just spending more time working with clades and this is invaluable. I don't have any changes to request and I think I can merge this given that it's a single file in scripts/ and doesn't risk breaking anything.

Although, I don't understand how Codecov is reporting that this changes test coverage in tree.py, utils.py, filter.py. None of these files were touched by this PR. This seems very strange to me. Oh, is it that this isn't a true diff? Instead it's running tests on current master and running tests on this branch and seeing there's a difference? A little annoying, but perhaps not so much of an issue for more recent PRs.

@trvrb trvrb merged commit 27e4b88 into master Dec 31, 2020
@trvrb trvrb deleted the emerging-clades branch December 31, 2020 06:16
@huddlej
Copy link
Contributor

huddlej commented Dec 31, 2020

I think you're right that Codecov is diffing between current master and this branch. I take these reports with a grain of salt and only inspect them when I know I've added tests.

@huddlej huddlej added this to the Feature release 10.X.0 milestone Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants