Update call and expected returns from pandas's parse_time_string #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
==========================================
+ Coverage 26.58% 26.59% +0.01%
==========================================
Files 36 36
Lines 5278 5282 +4
Branches 1306 1307 +1
==========================================
+ Hits 1403 1405 +2
- Misses 3825 3826 +1
- Partials 50 51 +1
Continue to review full report at Codecov.
|
The API for `parse_time_string` changed recently to only return two values instead of three [1] and the function is no longer importable from the pandas core tools datetimes module as of version 1.1.0. Instead, we have to import the `parsing` module that exposes the `parse_time_string` function. This commit supports both the previous and new API's return values. This bug should affect anyone trying to run augur with pandas 1.1.0 but not users running earlier versions of pandas. [1] pandas-dev/pandas#31065
huddlej
force-pushed
the
fix-pandas-regression
branch
from
ad57d66 to
7b11575
Compare
tsibley
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
I've not tested this myself, but by inspection it looks good to me.
pandas.to_datetime() looks like the public API, but it only returns a pandas.Timestamp and doesn't provide the input resolution differentiator we use. So for now I'd say let's merge this, and we can circle back to switching to a public API later.
|
Thanks for the quick check, @tsibley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The API for
parse_time_stringchanged recently to only return two values instead of three and the function is no longer importable from the pandas core tools datetimes module as of version 1.1.0. Instead, we have to import theparsingmodule that exposes theparse_time_stringfunction. This commit supports both the previous and new API's return values.This bug should affect anyone trying to run augur with pandas 1.1.0 but not users running earlier versions of pandas.
We might consider not using this pandas function if it is truly part of pandas' internal API.
Testing
To test this, I setup the same environment as the CI and confirmed that the test failed. After applying the patch from this PR, the test passes.