Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep log files produced by augur tree #572

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Keep log files produced by augur tree #572

merged 1 commit into from
Jun 26, 2020

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Jun 26, 2020

Removes all lines where tree builders remove log files during the clean up step
such that users can inspect logs after any run (successful or
unsuccessful). Updates functional test for the Zika build to confirm that the
log file exists as expected after running.

This commit also updates the functional tests for the Zika build such they
always run the local augur executable (i.e., the one relative to the test
directory). This change is most helpful when running tests on a local copy of
the repository where a global augur install might already exist.

This issue was raised on the Nextstrain discussion board.

Removes all lines where tree builders remove log files during the clean up step
such that users can inspect logs after any run (successful or
unsuccessful). Updates functional test for the Zika build to confirm that the
log file exists as expected after running.

This commit also updates the functional tests for the Zika build such they
always run the local augur executable (i.e., the one relative to the test
directory). This change is most helpful when running tests on a local copy of
the repository where a global augur install might already exist.
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #572 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   23.70%   23.72%   +0.01%     
==========================================
  Files          32       32              
  Lines        5159     5155       -4     
  Branches     1300     1298       -2     
==========================================
  Hits         1223     1223              
+ Misses       3885     3881       -4     
  Partials       51       51              
Impacted Files Coverage Δ
augur/tree.py 9.94% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e5081...7ce221f. Read the comment docs.

@huddlej huddlej requested review from jameshadfield and rneher June 26, 2020 02:40
@jameshadfield
Copy link
Member

The log-related changes look fine to me :)
I've never used bin/augur since I run an editable pip install so can't comment there but this seems sensible

Copy link
Member

@rneher rneher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thanks!

@huddlej huddlej merged commit 4b3c6ff into master Jun 26, 2020
@huddlej huddlej deleted the keep-logs branch June 26, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants