Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: Support ISO 8601 YYYY-MM-DD syntax for --max-date and --min-date #568

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Jun 18, 2020

Using YYYY-MM-DD is much more intuitive for folks not used to Augur's
style of numeric dates, and we can easily support both.

Resolves #567.

Using YYYY-MM-DD is much more intuitive for folks not used to Augur's
style of numeric dates, and we can easily support both.

Resolves #567.
@tsibley tsibley requested a review from kairstenfay June 18, 2020 17:08
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #568 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   20.92%   21.03%   +0.10%     
==========================================
  Files          31       31              
  Lines        5133     5140       +7     
  Branches     1300     1300              
==========================================
+ Hits         1074     1081       +7     
  Misses       4007     4007              
  Partials       52       52              
Impacted Files Coverage Δ
augur/filter.py 43.01% <100.00%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff315f...e67d3df. Read the comment docs.

Copy link
Contributor

@kairstenfay kairstenfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this, Tom!

@emmahodcroft
Copy link
Member

This is great Tom, thank you for taking care of this!

@tsibley tsibley merged commit 3d76b22 into master Jun 18, 2020
@tsibley tsibley deleted the filter/iso-dates branch June 18, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept ISO 8601 dates in augur filter's max-date and min-date
3 participants