Update schemas to allow display defaults for transmission lines #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schemas and test builds updated to allow one to define a display default in a dataset JSON to toggle on/off the transmission lines (if available). See the corresponding auspice PR nextstrain/auspice#1152. Additionally, the logic for setting display_defaults within `augur export v2` is improved so that we no longer have to define the valid keys in the source code. Invalid keys are still identified via validating the JSONs against schemas.
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 19.49% 21.95% +2.46%
==========================================
Files 31 31
Lines 5068 5629 +561
Branches 1284 1617 +333
==========================================
+ Hits 988 1236 +248
- Misses 4057 4292 +235
- Partials 23 101 +78
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas and test builds updated to allow one to define a display default
in a dataset JSON to toggle on/off the transmission lines (if available).
See the corresponding auspice PR nextstrain/auspice#1152.
Additionally, the logic for setting display_defaults within
augur export v2isimproved so that we no longer have to define the valid keys in the source code.
Invalid keys are still identified via validating the JSONs against schemas.