Explicitly specify a file encoding of UTF-8 everywhere #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augur mostly assumes the default file encoding UTF-8, but this is only true on systems where the system default or default locale use UTF-8. On systems which use the POSIX "C" locale, for example, the Python's default file encoding is ASCII, which can cause encoding failures like that observed with `augur traits` in #559. UTF-8 is a near universal standard for encodings these days. Note that Python 3.7 includes PEP-0538 and PEP-0540 to help address the difference between this common assumption and the reality of default encodings, but a) they do not allow application code to reliably avoid specifying encodings and b) Augur supports 3.6 anyway. Resolves #559.
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
=======================================
Coverage 20.86% 20.86%
=======================================
Files 31 31
Lines 5138 5138
Branches 1305 1305
=======================================
Hits 1072 1072
Misses 4014 4014
Partials 52 52
Continue to review full report at Codecov.
|
rneher
approved these changes
May 29, 2020
|
I made and equivalent change in TreeTime: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augur mostly assumes the default file encoding UTF-8, but this is only
true on systems where the system default or default locale use UTF-8.
On systems which use the POSIX "C" locale, for example, the Python's
default file encoding is ASCII, which can cause encoding failures like
that observed with
augur traitsin #559. UTF-8 is a near universalstandard for encodings these days.
Note that Python 3.7 includes PEP-0538 and PEP-0540 to help address the
difference between this common assumption and the reality of default
encodings, but a) they do not allow application code to reliably avoid
specifying encodings and b) Augur supports 3.6 anyway.
Resolves #559.