Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print treetime version #552

Merged
merged 1 commit into from
May 20, 2020
Merged

print treetime version #552

merged 1 commit into from
May 20, 2020

Conversation

jameshadfield
Copy link
Member

Depending on the install mechanism it seems possible to have an older-than-asked-for treetime
version in use, which can lead to confusing errors. Here we print the version of treetime
used for the commands which use it (excluding those which use a helper command such as read_vcf)
This is printed before the treetime command is run so that it's visible if that fails.

Depending on the install mechanism it seems possible to have an older-than-asked-for treetime
version in use, which can lead to confusing errors. Here we print the version of treetime
used for the commands which use it (excluding those which use a helper command such as `read_vcf`)
This is printed before the treetime command is run so that it's visible if that fails.
@jameshadfield jameshadfield requested a review from rneher May 19, 2020 23:44
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #552 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   19.49%   19.47%   -0.02%     
==========================================
  Files          31       31              
  Lines        5068     5073       +5     
  Branches     1284     1284              
==========================================
  Hits          988      988              
- Misses       4057     4062       +5     
  Partials       23       23              
Impacted Files Coverage Δ
augur/ancestral.py 11.00% <0.00%> (-0.12%) ⬇️
augur/refine.py 5.45% <0.00%> (-0.07%) ⬇️
augur/traits.py 7.82% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfed26d...30eea4b. Read the comment docs.

Copy link
Member

@rneher rneher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this should be useful.

@jameshadfield jameshadfield merged commit 5c251e7 into master May 20, 2020
@jameshadfield jameshadfield deleted the print-treetime-version branch May 20, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants