Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate confidence arguments passed down to treetime #548

Merged
merged 1 commit into from
May 23, 2020

Conversation

rneher
Copy link
Member

@rneher rneher commented May 10, 2020

Description of proposed changes

@pauloluniyi ran into an issue where augur failed during refine due to inconsistent arguments handed off to treetime. (requesting confidence intervals with rate uncertainty for a fixed rate without specifying uncertainty for the rate).

This commit checks that no rate is provided, i.e. the rate is estimated from the data, before requesting confidence intervals with rate uncertainty.

Related issue(s)

Fixes #547
Related to neherlab/treetime#118

Testing

What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?

Thank you for contributing to Nextstrain!

…confidence intervals (covariance) from the data
@rneher rneher changed the title only set vary_rate=True in tt.run call if the rate is estimated with … Rate confidence arguments passed down to treetime May 10, 2020
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #548 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   19.16%   19.16%           
=======================================
  Files          31       31           
  Lines        5072     5072           
  Branches     1289     1289           
=======================================
  Hits          972      972           
  Misses       4077     4077           
  Partials       23       23           
Impacted Files Coverage Δ
augur/refine.py 5.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704f369...2f05254. Read the comment docs.

@rneher rneher merged commit c152c1c into master May 23, 2020
@rneher rneher deleted the fix/rate-confidence-options branch May 23, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with treetime when running a nextstrain build
1 participant