Rate confidence arguments passed down to treetime #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
@pauloluniyi ran into an issue where augur failed during refine due to inconsistent arguments handed off to treetime. (requesting confidence intervals with rate uncertainty for a fixed rate without specifying uncertainty for the rate).
This commit checks that no rate is provided, i.e. the rate is estimated from the data, before requesting confidence intervals with rate uncertainty.
Related issue(s)
Fixes #547
Related to neherlab/treetime#118
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Thank you for contributing to Nextstrain!