Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coverage config file #491

Merged
merged 1 commit into from
Mar 30, 2020
Merged

add coverage config file #491

merged 1 commit into from
Mar 30, 2020

Conversation

willingc
Copy link
Contributor

Addresses #485

@elebow
Copy link
Contributor

elebow commented Mar 28, 2020

Should we add htmlcov/ to .gitignore?

@willingc
Copy link
Contributor Author

@elebow Yes, we should. Good catch. I did add it in an earlier open PR #486 https://github.com/nextstrain/augur/pull/486/files#diff-a084b794bc0759e7a6b77810e01874f2

Perhaps I should add here as well.

@tacaswell
Copy link
Contributor

We need to get this PR and #486 in. We also need to add the upload call to push stuff to codecov and someone with write privileges to set up the integrations?

@huddlej
Copy link
Contributor

huddlej commented Mar 30, 2020

@willingc @tacaswell This seems like a great direction. Would either of you be able to link to an example of how you're using codecov integrations on GitHub currently?

@tacaswell
Copy link
Contributor

https://github.com/matplotlib/matplotlib/blob/0e4685b8d89671bdf4a291a395a5ea11e503fe76/.travis.yml#L191 <- that is how we invoke pytest for Matplotlib.

https://github.com/matplotlib/matplotlib/blob/0e4685b8d89671bdf4a291a395a5ea11e503fe76/.travis.yml#L215 <- that is the line that uploads

If you look at any of our PRs (say matplotlib/matplotlib#16960) you will see 3 entries from codecov in the checks.

We also get status reports that look like https://codecov.io/gh/matplotlib/matplotlib

@huddlej
Copy link
Contributor

huddlej commented Mar 30, 2020

Thank you, @tacaswell! @trvrb is on board with this, so I am going to merge this. We will follow up about actually adding the integration to the Travis.

@huddlej huddlej merged commit b3b9e3d into nextstrain:master Mar 30, 2020
@willingc willingc deleted the add-covrc branch March 30, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants