Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min ver for pandas to 1.0.0 #488

Merged
merged 2 commits into from
May 23, 2020
Merged

Bump min ver for pandas to 1.0.0 #488

merged 2 commits into from
May 23, 2020

Conversation

groutr
Copy link
Contributor

@groutr groutr commented Mar 27, 2020

Description of proposed changes

The goal of this PR is depend on at least pandas 1.0.0. Starting with 1.0.0, pandas adopted an official versioning scheme for guaranteeing compatibility (https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.0.0.html#new-deprecation-policy). This was a concern the last time pandas min ver was updated (#144)

Related issue(s)

Related to #144, #482 (pandas 1.0.0 only supports Python >=3.6.1)
Fixes: #483

Testing

The test suite passes. I inspected all the usages of pandas and saw, as mentioned in #144, that the primary use of pandas is read_csv.

Thank you for contributing to Nextstrain!

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   19.16%   19.16%           
=======================================
  Files          31       31           
  Lines        5072     5072           
  Branches     1289     1289           
=======================================
  Hits          972      972           
  Misses       4077     4077           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704f369...a5326fd. Read the comment docs.

@rneher rneher merged commit 7168613 into nextstrain:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Bump pandas version to >=1.0.0
4 participants