Allow config/validate of branch_label
in display_defaults
#445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in the issue #444. We haven't integrated anything about the
display_defaults
propertybranch_label
(which is available now inauspice
) intoaugur
.This is mostly because we don't currently have any way in
augur
to generate many kinds of branch labels - onlyclade
andaa
. Ifclade
is available, it's shown by default, otherwise nothing is shown.However, as raised in the issue above, users may want to specify that
aa
is shown by default, or be able to specify that even thoughclade
is available, nothing should be shown by default.This PR gives a simple fix just to allow the inclusion of
branch_label
into v2-style 'config' files, allows these to be validated, allows them to be exported byexport v2
and again, allows them to validate.Currently the only options permitted are
aa
,clade
, andnone
. (None doesn't really do anything, but if you specify any non-valid entry,auspice
simply displays nothing for branch labels. So, this can be made semi-legit by just restricting users to these three options.)This should be updated to allow pretty much any value (excepting some special characters, probably) when we get around to integrating other ways of labelling branches into
augur
.