Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine: add argument for divergence unit #435

Merged
merged 1 commit into from
Jan 25, 2020
Merged

refine: add argument for divergence unit #435

merged 1 commit into from
Jan 25, 2020

Conversation

rneher
Copy link
Member

@rneher rneher commented Jan 25, 2020

this adds and argument --divergence-unit to refine with choices mutations and mutations-per-site (default). Thought was we might have a case with amino-acids or similar so keeping it general.
image

@rneher rneher requested a review from trvrb January 25, 2020 12:15
@trvrb
Copy link
Member

trvrb commented Jan 25, 2020

I really like this implementation. Testing worked well. I'm going to merge and push augur release.

@trvrb trvrb merged commit c21b4db into master Jan 25, 2020
@trvrb trvrb deleted the div_units branch January 25, 2020 16:02
@hackerchenzhuo
Copy link

good idea. by the way , what does it mean when it is default during divergence computing?

@tsibley
Copy link
Member

tsibley commented Feb 20, 2020

@hackerchenzhuo

what does it mean when it is default during divergence computing?

I assume you're asking about this bit of code:

augur/augur/refine.py

Lines 223 to 224 in 91f82f5

if args.divergence_units=='mutations-per-site': #default
pass

Internally divergence is always computed as mutations-per-site. If that's the desired output unit, then nothing needs to be done to convert the units before outputting. This is also the default output unit, meaning that if --divergence-unit mutations is not specified to augur refine, then it'll use mutations-per-site.

@hackerchenzhuo
Copy link

@hackerchenzhuo

what does it mean when it is default during divergence computing?

I assume you're asking about this bit of code:

augur/augur/refine.py

Lines 223 to 224 in 91f82f5

if args.divergence_units=='mutations-per-site': #default
pass

Internally divergence is always computed as mutations-per-site. If that's the desired output unit, then nothing needs to be done to convert the units before outputting. This is also the default output unit, meaning that if --divergence-unit mutations is not specified to augur refine, then it'll use mutations-per-site.

hi @tsibley
thank you for your reply
I have another question: can we comput the divergence between any two nodes? which means comput from any two different gene sequence rather than from root to other nodes like what discribe in algorithm?
Or maybe I have the wrong understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants