Fix weighted frequencies when weight keys are unrepresented #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works well for me. Thanks @huddlej! |
This was referenced Dec 11, 2019
Closed
huddlej
added a commit
to nextstrain/seasonal-flu
that referenced
this pull request
Dec 16, 2019
Resolves an issue with KDE frequency weighting where the regions used to weight frequencies were represented differently in the metadata and the weights JSON. For example, the metadata contains prettified regions like "North America" while the weights JSON referred to this region as "north america". This issue was revealed after introducing code to augur frequencies that eliminated all unrepresented weight attributes from consideration. When no weights were represented by the given tips (because of the casing difference shown above), weighted frequency estimation failed with a ValueError. [1] nextstrain/augur#420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of @huddlej's PR #418 onto the new v6
masterbranch.Closes #268.