feat: treat CDS as a valid feature for GFFs in load_features
#1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently don't load CDS features from GFF files Within Nextclade, we now treat CDS as the translatable unit, not gene So to use Nextclade GFF annotations in ancestral, we need to be able to read in CDS features Reading in CDS in addition to gene and source could potentially break some workflows that use gffs that have both gene and CDS features
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1332 +/- ##
=======================================
Coverage 65.79% 65.79%
=======================================
Files 68 68
Lines 7151 7151
Branches 1757 1757
=======================================
Hits 4705 4705
Misses 2182 2182
Partials 264 264 ☔ View full report in Codecov by Sentry. |
|
Is this still desired? I noticed |
|
Superseded by #1664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't load CDS features from GFF files
Within Nextclade, we now treat CDS as the translatable unit, not gene
So to use Nextclade GFF annotations in ancestral, we need to be able to read in CDS features
Reading in CDS in addition to gene and source could potentially break some workflows that use gffs that have both gene and CDS features