Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin Biopython to <=1.80 #1152

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: Pin Biopython to <=1.80 #1152

merged 1 commit into from
Feb 17, 2023

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Feb 17, 2023

1.81 is incompatible with BCBio.GFF which requires a module
that was removed in 1.81
Partially resolves #1151

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.
  • Tests pass, even for Biopython latest - which is exactly what we need

After release, make sure Bioconda gets the pin mirrored

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 68.17% // Head: 68.17% // No change to project coverage 👍

Coverage data is based on head (384f36b) compared to base (03a9188).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 384f36b differs from pull request most recent head a89cccb. Consider uploading reports for the commit a89cccb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          63       63           
  Lines        6752     6752           
  Branches     1654     1654           
=======================================
  Hits         4603     4603           
  Misses       1841     1841           
  Partials      308      308           
Impacted Files Coverage Δ
augur/__version__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corneliusroemer corneliusroemer marked this pull request as ready for review February 17, 2023 15:50
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pinning and a subsequent Augur release is the way to go here in the short term. Thanks for taking care of it. Then in the near term, I think either replacing BCBio.GFF or waiting for a fix in it (if it seems imminent).

A few minor notes below, but nothing super important.

1.81 is incompatible with BCBio.GFF which requires a module that was removed in 1.81

I'd suggest updating this commit message to s/module/class/ and include that the class in question is UnknownSeq.

CHANGES.md Outdated Show resolved Hide resolved
@corneliusroemer
Copy link
Member Author

@tsibley I added the class (I think you forgot to mention it) and how the error presents to users who get Biopython 1.81.

@tsibley
Copy link
Member

tsibley commented Feb 17, 2023

Even better! :-) One minor thing is the Markdown syntax isn't quite right:

image

@tsibley
Copy link
Member

tsibley commented Feb 17, 2023

(and the new commit's message says "README" but means "CHANGES")

1.81 is incompatible with BCBio.GFF which requires a module
that was removed in 1.81
Partially resolves #1151
@huddlej huddlej merged commit eef2a05 into master Feb 17, 2023
@huddlej huddlej deleted the pin-biopython branch February 17, 2023 18:31
corneliusroemer added a commit that referenced this pull request Mar 13, 2023
Biopython was fixed to <=1.80 in #1152
because bcbio-gff <=0.6.9 requires deprecated Biopython functionality that was removed in 1.81

A fix to bcbio-gff was released as 0.7.0, see chapmanb/bcbb#137 chapmanb/bcbb#136
So now we can pin bcbio-gff to >=0.7.0 and remove the pin
of Biopython

Note added in #1170 can hence be removed
corneliusroemer added a commit that referenced this pull request Mar 14, 2023
Biopython was fixed to <=1.80 in #1152
because bcbio-gff <=0.6.9 requires deprecated Biopython functionality that was removed in 1.81

A fix to bcbio-gff was released as 0.7.0, see chapmanb/bcbb#137 chapmanb/bcbb#136
So now we can pin bcbio-gff to >=0.7.0 and remove the pin
of Biopython

Note added in #1170 can hence be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Augur translate falsely claims BCBio.GFF not found when no features file passed
3 participants