-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pin Biopython to <=1.80 #1152
Conversation
Codecov ReportBase: 68.17% // Head: 68.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 68.17% 68.17%
=======================================
Files 63 63
Lines 6752 6752
Branches 1654 1654
=======================================
Hits 4603 4603
Misses 1841 1841
Partials 308 308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think pinning and a subsequent Augur release is the way to go here in the short term. Thanks for taking care of it. Then in the near term, I think either replacing BCBio.GFF or waiting for a fix in it (if it seems imminent).
A few minor notes below, but nothing super important.
1.81 is incompatible with BCBio.GFF which requires a module that was removed in 1.81
I'd suggest updating this commit message to s/module/class/ and include that the class in question is UnknownSeq
.
@tsibley I added the class (I think you forgot to mention it) and how the error presents to users who get Biopython 1.81. |
(and the new commit's message says "README" but means "CHANGES") |
1.81 is incompatible with BCBio.GFF which requires a module that was removed in 1.81 Partially resolves #1151
d85d718
to
a89cccb
Compare
Biopython was fixed to <=1.80 in #1152 because bcbio-gff <=0.6.9 requires deprecated Biopython functionality that was removed in 1.81 A fix to bcbio-gff was released as 0.7.0, see chapmanb/bcbb#137 chapmanb/bcbb#136 So now we can pin bcbio-gff to >=0.7.0 and remove the pin of Biopython Note added in #1170 can hence be removed
Biopython was fixed to <=1.80 in #1152 because bcbio-gff <=0.6.9 requires deprecated Biopython functionality that was removed in 1.81 A fix to bcbio-gff was released as 0.7.0, see chapmanb/bcbb#137 chapmanb/bcbb#136 So now we can pin bcbio-gff to >=0.7.0 and remove the pin of Biopython Note added in #1170 can hence be removed
1.81 is incompatible with BCBio.GFF which requires a module
that was removed in 1.81
Partially resolves #1151
Checklist
After release, make sure Bioconda gets the pin mirrored