Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using titers with values below threshold #1107

Closed
wants to merge 1 commit into from

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Dec 7, 2022

Description of proposed changes

Attempts to include more titer data into models by detecting measurement values that are below a given threshold (e.g., "<40") and converting those values to a reasonable numerical value that is one two-fold dilution value less than the threshold (e.g., 20, in the example above). This change allows us to at least include these values in our titer models and the measurements panel, so we have a complete picture of all the data available. If this general approach makes sense, we might consider a similar approach for values above a given threshold, too.

Testing

  • Add functional tests
  • Confirm functional tests pass CI

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

Attempts to include more titer data into models by detecting measurement
values that are below a given threshold (e.g., "<40") and converting
those values to a reasonable numerical value that is one two-fold
dilution value less than the threshold (e.g., 20, in the example above).
This change allows us to at least include these values in our titer
models and the measurements panel, so we have a complete picture of all
the data available. If this general approach makes sense, we might
consider a similar approach for values _above_ a given threshold, too.
@huddlej
Copy link
Contributor Author

huddlej commented Jan 19, 2023

Superseded by #1118.

@huddlej huddlej closed this Jan 19, 2023
@huddlej huddlej deleted the wip/use-all-titers branch January 19, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant