Fix compatibility with Pandas 1.5.0 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas 1.5.0 was released earlier this morning and moved an exception class we use. Routine CI caught this backwards-incompatible change affecting our error handling for `augur filter --query …` evaluation. I audited for usage of other exceptions moved in the same upstream change (as noted in the release notes) and found none in Augur. Resolves: <#1049> Related-to: <pandas-dev/pandas#27656>
tsibley
force-pushed
the
trs/pandas-1.5.0-compat
branch
from
14a9404 to
0194b94
Compare
victorlin
approved these changes
Sep 19, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
=======================================
Coverage 61.74% 61.74%
=======================================
Files 52 52
Lines 6297 6297
Branches 1584 1584
=======================================
Hits 3888 3888
Misses 2138 2138
Partials 271 271 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 1.5.0 was released earlier this morning and moved an exception class we use. Routine CI caught this backwards-incompatible change affecting our error handling for
augur filter --query …evaluation.I audited for usage of other exceptions moved in the same upstream change (as noted in the release notes) and found none in Augur.
Resolves: #1049
Related-to: pandas-dev/pandas#27656